-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to go 1.23 #141
move to go 1.23 #141
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 22.66% 22.48% -0.18%
==========================================
Files 10 10
Lines 1337 1343 +6
==========================================
- Hits 303 302 -1
- Misses 1015 1024 +9
+ Partials 19 17 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, thanks @jotak
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Upgrading linter showed some potential actual bugs during cleanup / exit, where deferred functions aren't called when something like log.Fatal or os.Exit is called, so I had to move things around to fix that (basically: having functions returning errors in case of doing something Fatal, and dealing with fatality in caller)