Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to go 1.23 #141

Merged
merged 4 commits into from
Jan 8, 2025
Merged

move to go 1.23 #141

merged 4 commits into from
Jan 8, 2025

Conversation

jotak
Copy link
Member

@jotak jotak commented Dec 17, 2024

Upgrading linter showed some potential actual bugs during cleanup / exit, where deferred functions aren't called when something like log.Fatal or os.Exit is called, so I had to move things around to fix that (basically: having functions returning errors in case of doing something Fatal, and dealing with fatality in caller)

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 5.71429% with 66 lines in your changes missing coverage. Please review.

Project coverage is 22.48%. Comparing base (d541d19) to head (1a77e69).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
cmd/flow_capture.go 0.00% 38 Missing ⚠️
cmd/packet_capture.go 0.00% 18 Missing ⚠️
cmd/flow_db.go 40.00% 6 Missing ⚠️
e2e/cluster/kind.go 0.00% 3 Missing ⚠️
cmd/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   22.66%   22.48%   -0.18%     
==========================================
  Files          10       10              
  Lines        1337     1343       +6     
==========================================
- Hits          303      302       -1     
- Misses       1015     1024       +9     
+ Partials       19       17       -2     
Flag Coverage Δ
unittests 22.48% <5.71%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/root.go 22.77% <0.00%> (-2.23%) ⬇️
e2e/cluster/kind.go 0.00% <0.00%> (ø)
cmd/flow_db.go 51.35% <40.00%> (+1.35%) ⬆️
cmd/packet_capture.go 0.00% <0.00%> (ø)
cmd/flow_capture.go 29.78% <0.00%> (-0.56%) ⬇️

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, thanks @jotak

@jotak
Copy link
Member Author

jotak commented Jan 8, 2025

/approve

Copy link

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 8, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a291737 into netobserv:main Jan 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants