NETOBSERV-2030: deploy on master nodes #143
Conversation
|
/ok-to-test |
|
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=64e36ce make commands |
|
/label qe-approved |
|
@jotak / @msherif1234 can I please get a quick review here as this is trivial change with huge impact ? |
| @@ -17,6 +17,8 @@ spec: | |||
| serviceAccountName: netobserv-cli | |||
| hostNetwork: true | |||
| dnsPolicy: ClusterFirstWithHostNet | |||
| tolerations: | |||
| - operator: Exists | |||
There was a problem hiding this comment.
what does it mean to have just operator: Exists without a key?
There was a problem hiding this comment.
(btw, how does that work in the operator? I never realized we did anything special to have the agents on the master nodes, do we?)
There was a problem hiding this comment.
That's exactly how it's done on the operator actually:
https://github.com/netobserv/network-observability-operator/blob/1aaeb6b3c0719c9ef73667daa3a04df0d69fd3ba/pkg/helper/flowcollector.go#L227
It's a trick to skip taints:
// Operator represents a key's relationship to the value.
// Valid operators are Exists and Equal. Defaults to Equal.
// Exists is equivalent to wildcard for value, so that a pod can
// tolerate all taints of a particular category.
// +optional
There was a problem hiding this comment.
Ok, I learned something, thanks! :-)
Wondering if we should make it an option? Like, if we start capturing pcap on master nodes, wouldn't be a higher risk to make the whole cluster unstable?
There was a problem hiding this comment.
You can use the --node-selector option to filter out which node to target. I feel it's good enough.
#146 is adding a example with it
jotak
changed the title
|
@jpinsonneau: This pull request references NETOBSERV-2030 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Tolerations were missing to deploy on master nodes.
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.