NETOBSERV-1499 Github config for CLI #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinsonneau
force-pushed
the
1499
branch
4 times, most recently
from
59b3915 to
9038098
Compare
jpinsonneau
commented
Mar 11, 2024
.github/workflows/pull_request.yml
Outdated
| files: ./cover.out | ||
| flags: unittests | ||
| fail_ci_if_error: false | ||
| args: --timeout 5m0s |
There was a problem hiding this comment.
@msherif1234 I'm getting a timeout here while linting (part of make build).
Any idea what is going on ?
https://github.com/netobserv/network-observability-cli/actions/runs/8236289627/job/22522495525
It's super fast locally
There was a problem hiding this comment.
adding --timeout=3m as same as in eBPF repo solved the issue but it still a nonsense to me
jpinsonneau
force-pushed
the
1499
branch
6 times, most recently
from
696c5f3 to
8c88f26
Compare
jpinsonneau
force-pushed
the
1499
branch
3 times, most recently
from
59801e7 to
af17985
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Merging this to get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding github files + miscs and allow injecting image from Make target
Also see prow configs: openshift/release#50198
Dependencies
Based on #3, merge it first and rebase when dependencies are updated
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.