Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mocks to cli #92

Merged
merged 1 commit into from
Dec 12, 2024
Merged

add mocks to cli #92

merged 1 commit into from
Dec 12, 2024

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Sep 19, 2024

Description

Add very simple mocks to the CLI to avoid running the whole stack for UI changes.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

openshift-ci bot commented Sep 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 4.44444% with 43 lines in your changes missing coverage. Please review.

Project coverage is 24.26%. Comparing base (0398f3b) to head (94cb017).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mocks.go 0.00% 37 Missing ⚠️
cmd/root.go 33.33% 4 Missing ⚠️
cmd/flow_capture.go 0.00% 1 Missing ⚠️
cmd/packet_capture.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   25.08%   24.26%   -0.83%     
==========================================
  Files           8        9       +1     
  Lines        1148     1191      +43     
==========================================
+ Hits          288      289       +1     
- Misses        839      881      +42     
  Partials       21       21              
Flag Coverage Δ
unittests 24.26% <4.44%> (-0.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/flow_capture.go 31.64% <0.00%> (-0.10%) ⬇️
cmd/packet_capture.go 0.00% <0.00%> (ø)
cmd/root.go 45.65% <33.33%> (-1.97%) ⬇️
cmd/mocks.go 0.00% <0.00%> (ø)

@jpinsonneau jpinsonneau force-pushed the mocks branch 2 times, most recently from 9089ba6 to e56a486 Compare October 16, 2024 09:28
Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 00192b6 into netobserv:main Dec 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants