Ensure admin cannot unassign SAML group members

Co-authored-by: Jonathan Treffler <[email protected]> Co-authored-by: Giuliano Mele <[email protected]>
netzbegruenung · Aug 20, 2021 · f29f3ce · f29f3ce
1 parent bbdb3b5
commit f29f3ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/lib/GroupBackend.php b/lib/GroupBackend.php
@@ -8,12 +8,9 @@
 use OCP\Group\Backend\ABackend;
 use OCP\Group\Backend\IAddToGroupBackend;
 use OCP\Group\Backend\ICountUsersBackend;
-use OCP\Group\Backend\ICreateGroupBackend;
-use OCP\Group\Backend\IDeleteGroupBackend;
-use OCP\Group\Backend\IRemoveFromGroupBackend;
 use OCP\IDBConnection;
 
-class GroupBackend extends ABackend implements IAddToGroupBackend, IRemoveFromGroupBackend, ICountUsersBackend {
+class GroupBackend extends ABackend implements IAddToGroupBackend, ICountUsersBackend {
 	/** @var IDBConnection */
 	private $dbc;
 

diff --git a/lib/GroupManager.php b/lib/GroupManager.php
@@ -119,7 +119,7 @@ public function removeGroup(IUser $user, string $gid) {
 		if($group === null) {
 			return;
 		}
-		$group->removeUser($user);
+		$this->ownGroupBackend->removeFromGroup($user->getUID(), $group->getGID());
 		if ($this->ownGroupBackend->countUsersInGroup($gid) === 0) {
 			$this->ownGroupBackend->deleteGroup($group->getGID());
 		}