Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alternative app icons to expo prebuild pipeline #158

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
257 changes: 123 additions & 134 deletions CHANGELOG.md

Large diffs are not rendered by default.

48 changes: 46 additions & 2 deletions app.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@
"UIViewControllerBasedStatusBarAppearance": false,
"NSLocationWhenInUseUsageDescription": "Allow Neuland Next to access your location to show your location on the map."
},
"icon": "./src/assets/appIcons/default.png"
"icon": {
"light": "./src/assets/appIcons/default.png",
"dark": "./src/assets/appIcons/dark/defaultDark.png",
"tinted": "./src/assets/appIcons/tinted/darkTinted.png"
}
},
"locales": {
"en": "./src/localization/en/ios.json",
Expand Down Expand Up @@ -59,7 +63,47 @@
"headOrigin": "https://neuland.app"
}
],
["expo-alternate-app-icons"],
[
"expo-alternate-app-icons",
[
{
"name": "Cat", // The name of the alternate icon
"ios": "./src/assets/appIcons/cat.png" // Path to iOS ico
},
{
"name": "RainbowNeon", // The name of the alternate icon
"ios": "./src/assets/appIcons/rainbowNeon.png" // Path to iOS ico
},
{
"name": "Retro", // The name of the alternate icon
"ios": "./src/assets/appIcons/retro.png" // Path to iOS ico
},
{
"name": "ModernGreen", // The name of the alternate icon
"ios": {
"light": "./src/assets/appIcons/modernGreen.png",
"dark": "./src/assets/appIcons/dark/modernGreenDark.png",
"tinted": "./src/assets/appIcons/tinted/darkTinted.png"
}
},
{
"name": "ModernPink", // The name of the alternate icon
"ios": {
"light": "./src/assets/appIcons/modernPurple.png",
"dark": "./src/assets/appIcons/dark/purpleDark.png",
"tinted": "./src/assets/appIcons/tinted/darkTinted.png"
}
},
{
"name": "RainbowMoonLight", // The name of the alternate icon
"ios": {
"light": "./src/assets/appIcons/rainbowMoonLight.png",
"dark": "./src/assets/appIcons/dark/darkRainbow.png",
"tinted": "./src/assets/appIcons/tinted/darkTinted.png"
}
}
]
],
["expo-secure-store"],
["expo-localization"],
[
Expand Down
74 changes: 71 additions & 3 deletions ios/NeulandNext.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@
28E106C6BAB84F5988F34B8E /* Remove signature files (Xcode workaround) */,
A2D2C10D14CA58FA7F8CA7B2 /* [CP] Embed Pods Frameworks */,
0124471C30E892434097B081 /* [CP] Copy Pods Resources */,
595B2ACD5CF84BDFAF84A1B6 /* Remove signature files (Xcode workaround) */,
173600D85F854ADFBE5F9DD0 /* Remove signature files (Xcode workaround) */,
);
buildRules = (
);
Expand Down Expand Up @@ -377,6 +379,40 @@
shellPath = /bin/sh;
shellScript = "# This script configures Expo modules and generates the modules provider file.\nbash -l -c \"./Pods/Target\\ Support\\ Files/Pods-NeulandNext/expo-configure-project.sh\"\n";
};
595B2ACD5CF84BDFAF84A1B6 /* Remove signature files (Xcode workaround) */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
name = "Remove signature files (Xcode workaround)";
inputPaths = (
);
outputPaths = (
);
shellPath = /bin/sh;
shellScript = "
echo \"Remove signature files (Xcode workaround)\";
rm -rf \"$CONFIGURATION_BUILD_DIR/MapLibre.xcframework-ios.signature\";
";
};
173600D85F854ADFBE5F9DD0 /* Remove signature files (Xcode workaround) */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
name = "Remove signature files (Xcode workaround)";
inputPaths = (
);
outputPaths = (
);
shellPath = /bin/sh;
shellScript = "
echo \"Remove signature files (Xcode workaround)\";
rm -rf \"$CONFIGURATION_BUILD_DIR/MapLibre.xcframework-ios.signature\";
";
};
/* End PBXShellScriptBuildPhase section */

/* Begin PBXSourcesBuildPhase section */
Expand Down Expand Up @@ -425,13 +461,21 @@
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_DEBUG";
PRODUCT_BUNDLE_IDENTIFIER = "de.neuland-ingolstadt.neuland-app";
PRODUCT_NAME = NeulandNext;
PRODUCT_NAME = "NeulandNext";
PROVISIONING_PROFILE_SPECIFIER = "";
SWIFT_OBJC_BRIDGING_HEADER = "NeulandNext/NeulandNext-Bridging-Header.h";
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
VERSIONING_SYSTEM = "apple-generic";
ASSETCATALOG_COMPILER_ALTERNATE_APPICON_NAMES = (
Cat,
RainbowNeon,
Retro,
ModernGreen,
ModernPink,
RainbowMoonLight,
);
};
name = Debug;
};
Expand All @@ -447,7 +491,7 @@
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = FSXB76X6V2;
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = arm64;
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "arm64";
INFOPLIST_FILE = NeulandNext/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 15.1;
LD_RUNPATH_SEARCH_PATHS = (
Expand All @@ -462,12 +506,20 @@
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_RELEASE";
PRODUCT_BUNDLE_IDENTIFIER = "de.neuland-ingolstadt.neuland-app";
PRODUCT_NAME = NeulandNext;
PRODUCT_NAME = "NeulandNext";
PROVISIONING_PROFILE_SPECIFIER = "";
SWIFT_OBJC_BRIDGING_HEADER = "NeulandNext/NeulandNext-Bridging-Header.h";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
VERSIONING_SYSTEM = "apple-generic";
ASSETCATALOG_COMPILER_ALTERNATE_APPICON_NAMES = (
Cat,
RainbowNeon,
Retro,
ModernGreen,
ModernPink,
RainbowMoonLight,
);
};
name = Release;
};
Expand Down Expand Up @@ -545,6 +597,14 @@
SDKROOT = iphoneos;
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) DEBUG";
USE_HERMES = true;
ASSETCATALOG_COMPILER_ALTERNATE_APPICON_NAMES = (
Cat,
RainbowNeon,
Retro,
ModernGreen,
ModernPink,
RainbowMoonLight,
);
};
name = Debug;
};
Expand Down Expand Up @@ -614,6 +674,14 @@
SDKROOT = iphoneos;
USE_HERMES = true;
VALIDATE_PRODUCT = YES;
ASSETCATALOG_COMPILER_ALTERNATE_APPICON_NAMES = (
Cat,
RainbowNeon,
Retro,
ModernGreen,
ModernPink,
RainbowMoonLight,
);
};
name = Release;
};
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"images" : [
{
"filename" : "default.png",
"filename" : "App-Icon-1024x1024@1x.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
Expand All @@ -13,7 +13,7 @@
"value" : "dark"
}
],
"filename" : "defaultDark.png",
"filename" : "App-Icon-dark-1024x1024@1x.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
Expand All @@ -25,7 +25,7 @@
"value" : "tinted"
}
],
"filename" : "darkTinted.png",
"filename" : "App-Icon-tinted-1024x1024@1x.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
Expand Down
Binary file not shown.
18 changes: 9 additions & 9 deletions ios/NeulandNext/Images.xcassets/Cat.appiconset/Contents.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"images" : [
"images": [
{
"filename" : "cat.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
"filename": "cat.png",
"idiom": "universal",
"platform": "ios",
"size": "1024x1024"
}
],
"info" : {
"author" : "xcode",
"version" : 1
"info": {
"author": "expo",
"version": 1
}
}
}
Binary file modified ios/NeulandNext/Images.xcassets/Cat.appiconset/cat.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1,38 +1,38 @@
{
"images" : [
"images": [
{
"filename" : "modernGreen.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
"filename": "modernGreen-light.png",
"idiom": "universal",
"platform": "ios",
"size": "1024x1024"
},
{
"appearances" : [
"filename": "modernGreenDark-dark.png",
"idiom": "universal",
"platform": "ios",
"size": "1024x1024",
"appearances": [
{
"appearance" : "luminosity",
"value" : "dark"
"appearance": "luminosity",
"value": "dark"
}
],
"filename" : "modernGreenDark.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
]
},
{
"appearances" : [
"filename": "darkTinted-tinted.png",
"idiom": "universal",
"platform": "ios",
"size": "1024x1024",
"appearances": [
{
"appearance" : "luminosity",
"value" : "tinted"
"appearance": "luminosity",
"value": "tinted"
}
],
"filename" : "darkTinted.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
]
}
],
"info" : {
"author" : "xcode",
"version" : 1
"info": {
"author": "expo",
"version": 1
}
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1,38 +1,38 @@
{
"images" : [
"images": [
{
"filename" : "modernPurple.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
"filename": "modernPurple-light.png",
"idiom": "universal",
"platform": "ios",
"size": "1024x1024"
},
{
"appearances" : [
"filename": "purpleDark-dark.png",
"idiom": "universal",
"platform": "ios",
"size": "1024x1024",
"appearances": [
{
"appearance" : "luminosity",
"value" : "dark"
"appearance": "luminosity",
"value": "dark"
}
],
"filename" : "purpleDark.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
]
},
{
"appearances" : [
"filename": "darkTinted-tinted.png",
"idiom": "universal",
"platform": "ios",
"size": "1024x1024",
"appearances": [
{
"appearance" : "luminosity",
"value" : "tinted"
"appearance": "luminosity",
"value": "tinted"
}
],
"filename" : "darkTinted.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
]
}
],
"info" : {
"author" : "xcode",
"version" : 1
"info": {
"author": "expo",
"version": 1
}
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading