Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Dotnet init windows latest tag #10

Merged
merged 2 commits into from
Oct 30, 2024
Merged

docs: Dotnet init windows latest tag #10

merged 2 commits into from
Oct 30, 2024

Conversation

andrew-lozoya
Copy link

@andrew-lozoya andrew-lozoya commented Oct 30, 2024 •
edited
Loading

Description

  • Added latest tagging workflow and manifest logic to the Windows init container build.
  • Resolved [new-line-at-end-of-file] linter error by adding a newline at the end of Chart.yaml.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@andrew-lozoya
dodnet-windows latest tag
c270196
@andrew-lozoya
Update Chart.yaml
92b4780 
[new-line-at-end-of-file] no new line character at the end of file
@andrew-lozoya andrew-lozoya changed the title doc: Dotnet init windows latest tag docs: Dotnet init windows latest tag Oct 30, 2024
@andrew-lozoya andrew-lozoya self-assigned this Oct 30, 2024
@andrew-lozoya andrew-lozoya requested a review from pnvnd October 30, 2024 20:28
@andrew-lozoya andrew-lozoya merged commit 732d2e8 into main Oct 30, 2024
37 checks passed
pnvnd
pnvnd reviewed Oct 30, 2024
View reviewed changes
Copy link

@pnvnd pnvnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnvnd pnvnd pnvnd left review comments

Assignees

@andrew-lozoya andrew-lozoya

Labels
Release/other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-lozoya @pnvnd