feat: Add automatic instrumentation of MassTransit clients v7 and v8. #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1972 +/- ##
==========================================
- Coverage 80.22% 80.22% -0.01%
==========================================
Files 404 404
Lines 24927 24932 +5
Branches 3003 3003
==========================================
+ Hits 19998 20001 +3
- Misses 4143 4146 +3
+ Partials 786 785 -1
|
* Initial exerciser implementation * Cleanup * Build works for all TFMS * Add legacy (7.x) exerciser Also cleanup, and rename start/stop methods * Unify v7/v8 exercisers Also pass in queue name as a parameter to StartBus to help with test assertions * Implement send * Adding alternate instrumentation point and first pass at tests (#2001) * Checkpoint trying to get hosted service model working for v7 * Message consume is working in v7! * Add instrumentation project readmes * Added regex scope, tests are passing * Test send as well as publish; cleanup * Expanded tests, updated instrumentation for v7 * Make regex metric name assertions more specific --------- Co-authored-by: Chris Hynes <[email protected]>
* Updated 7x instrumentation with version ranges Not quite working, integration tests are failing for StartBus with v7.0.0 due to transaction scope oddness * Tweak names * Better ConsoleMF logging Added millisecond-level timestamps and thread id * Only support 7.1.0 -> 7.3.1 * Actually make Tid a property * Enable MassTransit integration tests * Fix bug with transaction leakage * Also detach from primary in 8.x filter * Update project dependencies
nr-ahemsath
requested review from
a team,
jaffinito,
nrcventura,
chynesNR,
tippmar-nr and
dotnet-agent-team-bot
chynesNR
reviewed
Nov 2, 2023
nrcventura
approved these changes
Nov 3, 2023
tippmar-nr
added a commit
that referenced
this pull request
Dec 5, 2023
Merged
4 tasks
tippmar-nr
added a commit
that referenced
this pull request
Dec 5, 2023
This was referenced Jul 7, 2024
This was referenced Jul 28, 2024
This was referenced Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1282 by adding automatic instrumentation of MassTransit clients v7 and v8, for both .NET Framework and .NET Core/6+ applications.
Reminder: when this is merged, make sure to include a changelog entry for the RabbitMQ instrumentation changes.
Use the "summary" format where the main squash commit message looks like
summary: {overall feature description}and then add individualfeat(orfix,chore, etc.) lines in the extended description. Include the line below for RabbitMQ:BEGIN_COMMIT_OVERRIDE
feat: Add automatic instrumentation of MassTransit clients v7.1.0 and newer. #1282
feat: Update RabbitMQ instrumentation to capture more message consumption scenarios.
END_COMMIT_OVERRIDE