Limit MassTransit v7 support to 7.1.0 and higher #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not quite working, integration tests are failing for StartBus with v7.0.0 due to transaction scope oddness
Added millisecond-level timestamps and thread id
nr-ahemsath
requested review from
a team,
jaffinito,
nrcventura,
chynesNR,
tippmar-nr and
dotnet-agent-team-bot
tippmar-nr
reviewed
Nov 1, 2023
...ntegrationTests/SharedApplications/Common/MultiFunctionApplicationHelpers/ConsoleMFLogger.cs
Outdated
Show resolved
Hide resolved
tippmar-nr
approved these changes
Nov 1, 2023
chynesNR
approved these changes
Nov 1, 2023
nrcventura
approved these changes
Nov 1, 2023
jaffinito
approved these changes
Nov 2, 2023
Codecov Report
@@ Coverage Diff @@
## feature/auto-instrument-masstransit #2024 +/- ##
======================================================================
Coverage ? 80.43%
======================================================================
Files ? 402
Lines ? 24628
Branches ? 2960
======================================================================
Hits ? 19810
Misses ? 4039
Partials ? 779 |
nr-ahemsath
merged commit c645b4c
into
feature/auto-instrument-masstransit
74 checks passed
nr-ahemsath
deleted the
feature-work/better-masstransit-v7-instrumentation-versioning
branch
nr-ahemsath
added a commit
that referenced
this pull request
Nov 3, 2023
…#1972) * Add auto-instrumentation for MassTransit v7 and v8. * Update RabbitMQ HandleBasicDeliver instrumentation * Clean up POC branch (#1970) * Add integration tests for MassTransit (#2014) * Initial exerciser implementation * Cleanup * Build works for all TFMS * Add legacy (7.x) exerciser Also cleanup, and rename start/stop methods * Unify v7/v8 exercisers Also pass in queue name as a parameter to StartBus to help with test assertions * Implement send * Adding alternate instrumentation point and first pass at tests (#2001) * Checkpoint trying to get hosted service model working for v7 * Message consume is working in v7! * Add instrumentation project readmes * Added regex scope, tests are passing * Test send as well as publish; cleanup * Expanded tests, updated instrumentation for v7 * Make regex metric name assertions more specific --------- Co-authored-by: Chris Hynes <[email protected]> * Limit MassTransit v7 support to 7.1.0 and higher (#2024) * Updated 7x instrumentation with version ranges Not quite working, integration tests are failing for StartBus with v7.0.0 due to transaction scope oddness * Tweak names * Better ConsoleMF logging Added millisecond-level timestamps and thread id * Only support 7.1.0 -> 7.3.1 * Actually make Tid a property * Enable MassTransit integration tests * Fix bug with transaction leakage * Also detach from primary in 8.x filter * Update project dependencies * Fix merge issues * Fix more merge mistakes --------- Co-authored-by: Jacob Affinito <[email protected]> Co-authored-by: Chris Hynes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing has shown behavioral differences in MassTransit 7.0.x versions that cause integration test failures. This PR updates the 7.x instrumentation file for MT to restrict matching to 7.1.0 and higher. The integration tests are updated to test 7.1.0 as the earliest version.
This also contains an improvement to how the ConsoleMF test application logs its output, adding millisecond-level timing info and the current managed thread ID (to help troubleshoot async thread hopping issues).
Author Checklist
Reviewer Checklist