Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): NuGet updates, dead code removal #2026

Merged
merged 7 commits into from
Nov 4, 2023

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Nov 3, 2023

  • Updates Serilog to v3.0.1 (from 2.12.2) which should bring some performance improvements and general goodness. See Serilog v3.0.0 for details.
  • Updates Core.csproj ILRepack configuration to move packages used in both net462 and netstandard2.0 to the "common" configuration rather than repeating them in the tfm-specific sections.
  • Updates several NuGet packages (nUnit, xUnit, coverlet.collector, etc.) used in our unit, integration and unbounded test projects.
  • Fixes unit tests in NewRelic.Testing.Assertions.UnitTests that were broken with the update to the latest nUnit version.
  • Removes NoOpAttributeValueCollection class as it is unused anywhere.

@codecov-commenter
Copy link

Codecov Report

Merging #2026 (1c0e7bf) into main (14c6bb1) will increase coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2026      +/-   ##
==========================================
+ Coverage   80.22%   80.30%   +0.07%     
==========================================
  Files         404      404              
  Lines       24927    24903      -24     
  Branches     3003     3003              
==========================================
  Hits        19998    19998              
+ Misses       4143     4119      -24     
  Partials      786      786              
Files Coverage Δ
.../Agent/Core/Attributes/AttributeValueCollection.cs 82.59% <ø> (+8.01%) ⬆️

... and 2 files with indirect coverage changes

@tippmar-nr tippmar-nr merged commit 2693125 into main Nov 4, 2023
74 checks passed
@tippmar-nr tippmar-nr deleted the chore/nuget-updates branch November 4, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants