-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Increase profiler test coverage #2027
Merged
nrcventura
merged 12 commits into
feature/unified-in-agent-method-cache
from
feature-work/increase-profiler-test-coverage
Nov 6, 2023
Merged
chore: Increase profiler test coverage #2027
nrcventura
merged 12 commits into
feature/unified-in-agent-method-cache
from
feature-work/increase-profiler-test-coverage
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/unified-in-agent-method-cache #2027 +/- ##
========================================================================
Coverage ? 84.81%
========================================================================
Files ? 44
Lines ? 2713
Branches ? 0
========================================================================
Hits ? 2301
Misses ? 412
Partials ? 0 |
nrcventura
requested review from
a team,
jaffinito,
nr-ahemsath,
chynesNR,
tippmar-nr and
dotnet-agent-team-bot
November 4, 2023 01:09
chynesNR
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
tippmar-nr
approved these changes
Nov 6, 2023
nrcventura
merged commit Nov 6, 2023
2a93452
into
feature/unified-in-agent-method-cache
73 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.
Description
Increases the test coverage for many of the files that were changed on the feature branch.
The code in the Profiler project is not currently unit tested because of the dependencies on the COM APIs.
Author Checklist
Reviewer Checklist