Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Increase profiler test coverage #2027

Conversation

nrcventura
Copy link
Member

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

Increases the test coverage for many of the files that were changed on the feature branch.

The code in the Profiler project is not currently unit tested because of the dependencies on the COM APIs.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feature/unified-in-agent-method-cache@2349dfe). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                           Coverage Diff                            @@
##             feature/unified-in-agent-method-cache    #2027   +/-   ##
========================================================================
  Coverage                                         ?   84.81%           
========================================================================
  Files                                            ?       44           
  Lines                                            ?     2713           
  Branches                                         ?        0           
========================================================================
  Hits                                             ?     2301           
  Misses                                           ?      412           
  Partials                                         ?        0           

@nrcventura nrcventura marked this pull request as ready for review November 4, 2023 01:09
Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@nrcventura nrcventura merged commit 2a93452 into feature/unified-in-agent-method-cache Nov 6, 2023
73 checks passed
@nrcventura nrcventura deleted the feature-work/increase-profiler-test-coverage branch November 6, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants