Agent support for read-only file systems #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New option to disable logging * Env var for console logging * Supportability metric if logging fails
chynesNR
requested review from
a team,
jaffinito,
nrcventura,
nr-ahemsath,
tippmar-nr and
dotnet-agent-team-bot
Codecov Report
@@ Coverage Diff @@
## feature/read-only-file-systems #2045 +/- ##
=================================================================
Coverage ? 80.25%
=================================================================
Files ? 403
Lines ? 24880
Branches ? 2996
=================================================================
Hits ? 19967
Misses ? 4133
Partials ? 780 |
nrcventura
reviewed
Nov 9, 2023
nrcventura
reviewed
Nov 9, 2023
tests/Agent/UnitTests/Core.UnitTest/AgentHealth/AgentHealthReporterTests.cs
Outdated
Show resolved
Hide resolved
nrcventura
reviewed
Nov 9, 2023
nrcventura
reviewed
Nov 9, 2023
tests/Agent/UnitTests/Core.UnitTest/AgentHealth/AgentHealthReporterTests.cs
Outdated
Show resolved
Hide resolved
tippmar-nr
reviewed
Nov 9, 2023
tippmar-nr
approved these changes
Nov 9, 2023
nrcventura
approved these changes
Nov 9, 2023
chynesNR
merged commit 822c541
into
feature/read-only-file-systems
71 of 73 checks passed
nr-ahemsath
added a commit
that referenced
this pull request
Nov 21, 2023
…ms. (#2085) * Don't bail if log file can't be created * Support logging to stdout in the Profiler (#2025) * Agent support for read-only file systems (#2045) * New option to disable logging * Env var for console logging * Supportability metric if logging fails * Don't allow audit logging if logging is disabled * chore: Update Profiler NuGet Package Reference to v10.18.0.15. (#2077) Co-authored-by: nr-ahemsath <[email protected]> * Add integration tests for file logging disabled and console logging enabled (#2076) * Checkpoint in order to switch branches * Refactored AgentLogFile Moved AgentLogFile to the fixtures instead of the applications * Shorten some names * Fix bug caused by Visual Studio autocorrect * WIP * Working tests for logging disabled * Working console logging tests * Fix nuget package warnings-as-errors * Fix GuidConfigurationTests EndsWith() fails if the profiler logs the version, e.g. New Relic .NET CoreCLR Agent v10.18.0.26. Use Contains() instead * Fix integration test build error * PR feedback --------- Co-authored-by: chynesNR <[email protected]> Co-authored-by: Chris Hynes <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: nr-ahemsath <[email protected]> Co-authored-by: Marty Tippin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support on the Agent side to better handle read-only file systems:
log:enabled) and environment variable (NEW_RELIC_LOG_ENABLED) to disable logging completely. No file writes will be attempted.NEW_RELIC_LOG_CONSOLE) -- there is already an existing config setting.