fix: Update instrumentation to support Elasticsearch v8.11.0 #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippmar-nr
requested review from
a team,
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2100 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 395 395
Lines 24711 24711
Branches 2969 2969
=======================================
Hits 20035 20035
Misses 3890 3890
Partials 786 786 |
nrcventura
approved these changes
Nov 28, 2023
nr-ahemsath
reviewed
Nov 28, 2023
tests/Agent/IntegrationTests/UnboundedIntegrationTests/Elasticsearch/ElasticsearchTests.cs
Outdated
Show resolved
Hide resolved
tippmar-nr
deleted the
fix/update-elasticsearch-instrumentation-for-8-10-0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.
Description
Updates our Elasticsearch instrumentation to support version 8.11.0. The signature of an instrumented method changed with the v8.10.0 release.
Resolves #1951
Author Checklist
Reviewer Checklist