Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update integration tests to NLog v5.2.6 #2101

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

tippmar-nr
Copy link
Member

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

Updates integration tests to use NLog v5.2.6

Resolves #2086

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@codecov-commenter
Copy link

Codecov Report

Merging #2101 (b93f882) into main (7e521df) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2101      +/-   ##
==========================================
+ Coverage   81.06%   81.07%   +0.01%     
==========================================
  Files         395      395              
  Lines       24711    24711              
  Branches     2969     2969              
==========================================
+ Hits        20031    20035       +4     
+ Misses       3893     3890       -3     
+ Partials      787      786       -1     

see 1 file with indirect coverage changes

Copy link
Member

@nr-ahemsath nr-ahemsath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 👍

@tippmar-nr tippmar-nr merged commit 576adbe into main Nov 28, 2023
74 checks passed
@tippmar-nr tippmar-nr deleted the chore/nlog-integration-test-updates branch November 28, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dotty: update tests for nlog from 5.2.5 to 5.2.6
4 participants