Skip to content

Commit

Permalink
fixup! feat:select existing talk roomfor convesations
Browse files Browse the repository at this point in the history
Signed-off-by: greta <[email protected]>
  • Loading branch information
GretaD committed Jan 8, 2025
1 parent 6a099fa commit 1153693
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
9 changes: 5 additions & 4 deletions src/components/Editor/AddTalkModal.vue
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
<template>
<NcModal size="normal" class="modal" :name="t('calendar', 'Select a Talk Room')">
<div class="modal-content">
<h2>{{ t('calendar', 'Select a talk room from the list') }}</h2>
<h2>{{ t('calendar', 'Add Talk conversation') }}</h2>
<div class="talk-room-list">
<NcEmptyContent v-if="loading"
icon="icon-loading"
class="modal__content__loading"
:description="t('calendar','Fetching talk rooms...')" />
:description="t('calendar','Fetching Talk rooms...')" />
<NcEmptyContent v-else-if="talkConversations.length === 0"
:description="t('calendar','No talk room available')" />
:description="t('calendar','No Talk room available')" />
<ul v-else>
<li v-for="conversation in talkConversations"
:key="conversation.id"
:class="{ selected: selectedRoom && selectedRoom.id === conversation.id }"

Check warning on line 15 in src/components/Editor/AddTalkModal.vue

View check run for this annotation

Codecov / codecov/patch

src/components/Editor/AddTalkModal.vue#L11-L15

Added lines #L11 - L15 were not covered by tests
class="talk-room-list__item"
@click="selectRoom(conversation)">
<NcAvatar :url="avatarUrl(conversation)"
:size="44"
:size="34"
:disable-tooltip="true" />
<span>{{ conversation.displayName }}</span>
</li>
Expand Down Expand Up @@ -207,6 +207,7 @@ export default {
flex: 1;
overflow-y: auto;
padding: 10px;
font-weight: 600;
&__item {
display: flex;
Expand Down
5 changes: 0 additions & 5 deletions src/views/EditSidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -460,11 +460,6 @@ export default {
window.removeEventListener('keydown', this.keyboardDuplicateEvent)
},
methods: {
selectConversation(conversation) {
this.selectedConversation = conversation
this.applyConversationToEvent(conversation)
this.closeModal()
},
openModal() {
this.isModalOpen = true
},
Expand Down

0 comments on commit 1153693

Please sign in to comment.