-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to select contact groups as attendees #4742
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4742 +/- ##
============================================
+ Coverage 23.92% 23.96% +0.03%
- Complexity 455 460 +5
============================================
Files 247 247
Lines 11517 11557 +40
Branches 1934 1944 +10
============================================
+ Hits 2756 2770 +14
- Misses 8761 8787 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was also discussed in #3853 (comment). I think it would make sense and adds value in general. |
This sounds good to me as well. There should be something to indicate that there are multiple emails associated with one contact, especially when the group has many contacts. So we could possibly:
I would go with 2) because it's simple and doesn't require any scrolling to see that there are multiple email contacts |
For now I have added the suggestion from @ChristophWurst as it's the easy part. However I'm not sure it's needed if we show the emails in the attendee item subline as per 2. . In any case we really need to remove the « invitation sent » label until the event is saved and the invitations are really sent, as adding the email next to it will even more increase confusion. |
I fundamentally disagree with hiding the email address in the three dot menu. I think it should be visible immediately without user interaction as it is relevant information and belongs to the same sort of information as a Display Name is. |
from the user's perspective it is very simple: use the preferred email address (I'm waiting since long to be able to invite the Tenor voice section of our choit to extra rehersals including theit accept/decline replies.....) |
Talked a bit about this with @nimishavijay, we were going through the comments here and concluded:
What we can do is:
|
Any status on this one? :) I just got a question about this feature and went looking for a ticket for it :) |
@tcitworld are you happy to implement the changes Jan suggested? I can take over otherwise, excellent work btw. |
Hi, I'm a newbie but when this will be released ? Regards |
Hello all, great work ! Do you know when this feature will be implemented ? :D |
has there been any movement on this? |
It would be great, if someone will contiue the work. :) |
The lack of any way to easily add multiple email addresses as invitees to an event is crippling. I've tried pasting in a comma separated list of addresses (doesn't work), pasting in from Excel or similar (doesn't work), adding contacts to an address book and/or group in the Contacts app and trying to name the book or group in the invitees field. Any or all of these approaches would allow me to use Nextcloud calendar. This particular thread is 18 months old. I've come across others that stretch back to 2015 or beyond. |
Signed-off-by: Thomas Citharel <[email protected]>
Signed-off-by: Thomas Citharel <[email protected]>
710866c
to
392d969
Compare
Added the email as text next to the attendees: I think I broke the lovely #5396 |
Kooha-2022-11-17-17-46-51.webm
A significant limitation is that if a contact has multiple addresses, all of them will be added (as shown in the above video). Unfortunately once attendees are added, their email addresses are currently not shown, so you can't know which attendee item to remove.
I'm not sure what's the best way to proceed here and I'd like your opinion on that (as well as @nextcloud/designers ):
(Also the message « Group contains X contacts » kinda lies, it's about the attendees emails, not the attendees contacts.
Closes #167