Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP8.3 support #5542

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add PHP8.3 support #5542

merged 1 commit into from
Oct 20, 2023

Conversation

JohannesGGE
Copy link
Contributor

@JohannesGGE JohannesGGE commented Oct 20, 2023

Fix: #5507

@JohannesGGE JohannesGGE self-assigned this Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0581fd9) 22.28% compared to head (8c6431e) 24.83%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5542      +/-   ##
============================================
+ Coverage     22.28%   24.83%   +2.55%     
  Complexity      388      388              
============================================
  Files           240      240              
  Lines         11793    10568    -1225     
  Branches       2301     1708     -593     
============================================
- Hits           2628     2625       -3     
+ Misses         9165     7943    -1222     
Flag Coverage Δ
javascript 15.80% <ø> (+1.97%) ⬆️
php 63.27% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 95 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Johannes Merkel <[email protected]>
@JohannesGGE JohannesGGE marked this pull request as ready for review October 20, 2023 09:37
@JohannesGGE JohannesGGE added the 3. to review Waiting for reviews label Oct 20, 2023
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPUnit output is clean

@ChristophWurst ChristophWurst merged commit 2ec032c into main Oct 20, 2023
@ChristophWurst ChristophWurst deleted the feat/php8.3-support branch October 20, 2023 09:46
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PHP8.3 support
2 participants