Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont forward internal exceptions #5553

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 30, 2023

No description provided.

@kesselb kesselb self-assigned this Oct 30, 2023
@kesselb kesselb added 2. developing Work in progress bug labels Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a568764) 24.83% compared to head (3b5ecd0) 24.59%.
Report is 29 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5553      +/-   ##
============================================
- Coverage     24.83%   24.59%   -0.25%     
  Complexity      388      388              
============================================
  Files           240      240              
  Lines         10573    10575       +2     
  Branches       1710     1710              
============================================
- Hits           2626     2601      -25     
- Misses         7947     7974      +27     
Flag Coverage Δ
javascript 15.80% <0.00%> (-0.01%) ⬇️
php 62.02% <ø> (-1.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/services/appointmentConfigService.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kesselb kesselb force-pushed the bug/noid/appointment-config-error-handling branch 2 times, most recently from 74ebddd to eda79f5 Compare October 30, 2023 13:44
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the bug/noid/appointment-config-error-handling branch from eda79f5 to 3b5ecd0 Compare October 30, 2023 13:51
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 30, 2023
@kesselb kesselb added this to the v4.6.0 milestone Oct 30, 2023
@kesselb kesselb merged commit 4382955 into main Oct 30, 2023
40 of 42 checks passed
@kesselb kesselb deleted the bug/noid/appointment-config-error-handling branch October 30, 2023 16:10
@kesselb
Copy link
Contributor Author

kesselb commented Oct 30, 2023

/backport to stable4.5

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Oct 30, 2023
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants