Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: appointment slots start and end time #6499

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

SebastianKrupinski
Copy link
Contributor

Resolves: #6407
Resolves: #5913

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.43%. Comparing base (492beb5) to head (6e06e87).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6499      +/-   ##
============================================
- Coverage     23.46%   23.43%   -0.03%     
  Complexity      453      453              
============================================
  Files           247      247              
  Lines         11728    11724       -4     
  Branches       2212     2223      +11     
============================================
- Hits           2752     2748       -4     
  Misses         8656     8656              
  Partials        320      320              
Flag Coverage Δ
javascript 15.03% <ø> (ø)
php 59.29% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@SebastianKrupinski SebastianKrupinski force-pushed the fix/issue-6407-fix-appointment-slot branch 2 times, most recently from 785d741 to 9b88ea3 Compare November 19, 2024 01:43
@SebastianKrupinski
Copy link
Contributor Author

/backport to stable5.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Nov 19, 2024
@SebastianKrupinski
Copy link
Contributor Author

/backport to stable4.7

@SebastianKrupinski SebastianKrupinski force-pushed the fix/issue-6407-fix-appointment-slot branch from 9b88ea3 to 6e06e87 Compare November 19, 2024 13:53
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Time zones are tricky ...

tests/php/unit/Controller/BookingControllerTest.php Outdated Show resolved Hide resolved
tests/php/unit/Controller/BookingControllerTest.php Outdated Show resolved Hide resolved
tests/php/unit/Controller/BookingControllerTest.php Outdated Show resolved Hide resolved
tests/php/unit/Controller/BookingControllerTest.php Outdated Show resolved Hide resolved
@SebastianKrupinski SebastianKrupinski merged commit cafbc75 into main Nov 19, 2024
37 of 38 checks passed
@SebastianKrupinski SebastianKrupinski deleted the fix/issue-6407-fix-appointment-slot branch November 19, 2024 14:01
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
5 participants