Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add availability action to the contacts menu #6502

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Nov 19, 2024

Part of nextcloud/server#44776

Requires nextcloud/server#49375 and nextcloud-libraries/nextcloud-vue#6238

Add a new action to the contacts menu to show the user's availability. The plan is to reuse the free-busy modal for this.

TODO

  • Merge related pulls
  • Come up with a better icon (currently the clock icon)
  • Actually implement the modal (currently only a placeholder)
  • Version gate the feature to prevent unnecessary JS loading.
  • Initialize timezone, locale and settings

Screencasts

Avatar menu integration (from Talk)

2024-11-27.14-33-53.mp4

Contacts Menu integration (everywhere)

2024-11-27.14-35-29.mp4

@st3iny st3iny added 2. developing Work in progress enhancement New feature request labels Nov 19, 2024
@st3iny st3iny self-assigned this Nov 19, 2024
@st3iny st3iny added the Feature: Integration An integration with another app in the ecosystem label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 23.24%. Comparing base (c27f067) to head (266a345).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/views/ContactsMenuAvailability.vue 0.00% 41 Missing ⚠️
src/contactsMenu.js 0.00% 29 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6502      +/-   ##
============================================
- Coverage     23.41%   23.24%   -0.17%     
- Complexity      472      475       +3     
============================================
  Files           249      251       +2     
  Lines         11899    11986      +87     
  Branches       2268     2289      +21     
============================================
  Hits           2786     2786              
- Misses         8786     8873      +87     
  Partials        327      327              
Flag Coverage Δ
javascript 14.72% <0.00%> (-0.13%) ⬇️
php 59.30% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, so good 🙏

lib/AppInfo/Application.php Show resolved Hide resolved
@st3iny st3iny force-pushed the feat/js-hook-avatar-action branch from 45244b2 to 266a345 Compare January 9, 2025 13:43
@st3iny st3iny merged commit 4ebf8d3 into main Jan 10, 2025
37 of 39 checks passed
@st3iny st3iny deleted the feat/js-hook-avatar-action branch January 10, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request Feature: Integration An integration with another app in the ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants