Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable4.7] Event attachments: Enable directory selection #6545

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Dec 3, 2024

Backport of #6534

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added 3. to review Waiting for reviews bug labels Dec 3, 2024
@backportbot backportbot bot added this to the v4.7.17 milestone Dec 3, 2024
Although folder selection is possible, the callback does not receive the picked node unless `allowDirectories(true)` is explicitly set.

Signed-off-by: Daniel Kesselberg <[email protected]>
Fallback to the folder icon when a content type is missing.

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the backport/6534/stable4.7 branch from 1e2684e to b9f1a99 Compare December 3, 2024 17:59
@kesselb
Copy link
Contributor

kesselb commented Dec 3, 2024

Conflicts:

The onlyTime arguments for changeStartDateMutation does not exist => skip the commit

@kesselb kesselb marked this pull request as ready for review December 3, 2024 18:00
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 15.51%. Comparing base (6244a90) to head (b9f1a99).
Report is 9 commits behind head on stable4.7.

Files with missing lines Patch % Lines
.../components/Editor/Attachments/AttachmentsList.vue 0.00% 5 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           stable4.7    #6545      +/-   ##
=============================================
- Coverage      15.51%   15.51%   -0.01%     
=============================================
  Files            206      206              
  Lines           9256     9257       +1     
  Branches        1931     1931              
=============================================
  Hits            1436     1436              
- Misses          7820     7821       +1     
Flag Coverage Δ
javascript 15.51% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kesselb kesselb merged commit 87a3efb into stable4.7 Dec 4, 2024
41 of 42 checks passed
@kesselb kesselb deleted the backport/6534/stable4.7 branch December 4, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant