-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Sidebar editor repetition count for "days" #6551
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6551 +/- ##
=========================================
Coverage 23.44% 23.44%
Complexity 472 472
=========================================
Files 249 249
Lines 11888 11888
Branches 2282 2271 -11
=========================================
Hits 2787 2787
Misses 8774 8774
Partials 327 327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b94c7c0
to
91e0e7e
Compare
yes, @keremsemiz the "repeat every" field should be smaller, so both input field can fit in one row, because the content they hold is very small. So remove the flex-direction: column for that. The second part: end repeat. What you can do is, have a set width for the fields, and wrap them in a flex box to move below if theres no space. |
Yes, I understand what you mean. Originally I did it that way but I thought that the issue always needed them to be on seperate lines 👍 |
no problem, try this new approach when you have the time |
9d15e3d
to
0591fc0
Compare
Thank you for pointing that out, I'll make sure to fix it tomorrow. |
…te line #6429 Signed-off-by: Kerem Semiz <[email protected]>
Signed-off-by: Kerem Semiz <[email protected]>
Signed-off-by: Kerem Semiz <[email protected]>
f22d43f
to
e9612ee
Compare
@keremsemiz can you squash all the commits in to one and rebase please |
yep, did it. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fixes #6429
Adjusted CSS for proper centering of the Repeat section in the sidebar at low px counts.