Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 14.0.0.xml #7

Merged
merged 5 commits into from
Aug 22, 2018
Merged

Update 14.0.0.xml #7

merged 5 commits into from
Aug 22, 2018

Conversation

jospoortvliet
Copy link
Member

shorten 14 changelist

shorten 14 changelist
@jospoortvliet jospoortvliet requested a review from blizzz August 16, 2018 14:17
@blizzz blizzz requested a review from jancborchardt August 16, 2018 14:17
@blizzz
Copy link
Member

blizzz commented Aug 16, 2018

It's better…

screenshot_20180816_175746

but maybe there's more potential. Let me give it a try

@blizzz
Copy link
Member

blizzz commented Aug 16, 2018

  • the federation thing is maybe interesting for users, but nothing hot for admins. In the sense that nothing would trigger them doing an action
  • a lot of unnecessary details

Some shortened suggestions:

admin part:

  • Improved GDPR compliance through apps; separate audit log
  • Swiftv3 auth support; systemd logger
  • Kerberos auth to Samba; multi-IdP SAML

user part:

  • Verify a share recipient in a video call; 2FA with Signal & Telegram
  • Add a note to shares; extended share views; search by comments
  • Accessibility improvements including high contrast theme

screenshot_20180816_180935

Nevertheless I am not sure a user should be confronted with "2FA" and whether verification of people should be on the top. Would sort the second regular item topmost. Anyhow, decision on you. The idea behind those text is to BRIEFLY (yeah, i know it's hard) note down exciting things (regular users) and items that may require taking an action (admins. Btw, in this regard, dropped PHP 5 support would be noteworthy – or more positively phrased if you like). For everything else, there's the changelog (and announcement).

@rullzer
Copy link
Member

rullzer commented Aug 16, 2018

Swiftv3 auth support

No admin will care I bet. Because object store has to be setup before you install your Nextcloud.

@blizzz
Copy link
Member

blizzz commented Aug 16, 2018

So for the admin part, what about:

  • Requires PHP >= 7.0, log format, syslog tag & nginx config changed
  • Improved GDPR compliance through apps; separate audit log
  • Kerberos auth to Samba; multi-IdP SAML

First line inspired by nextcloud/server#7827

@MorrisJobke MorrisJobke added the enhancement New feature or request label Aug 20, 2018
@jospoortvliet
Copy link
Member Author

👍 those work for me, @blizzz

@blizzz
Copy link
Member

blizzz commented Aug 21, 2018

oh, btw, after learning that

2FA with Signal & Telegram

is experimental at best I am hesitant to include this, too.

data/14.0.0.xml Outdated
<item>Improved GDPR compliance capabilities with terms &amp; conditions app and separate audit log</item>
<item>Next generation of federated, cross-cloud sharing collaboration: Federation 2.0</item>
<item>Swiftv3 auth support, logging to systemd, Kerberos auth to Samba &amp; multi-IdP SAML</item>
<item>Improved GDPR compliance with terms &amp; conditions app; separate audit log</item>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the app is called terms of service

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, is being dropped anyway, cf #7 (comment)

data/14.0.0.xml Outdated
<item>Verify the identity of a share recipient in a video call; and 2FA with Signal &amp; Telegram</item>
<item>Add a note to shares, see pending &amp; deleted shares and search for files by content of comments</item>
<item>Accessibility improvements including dark &amp; high contrast themes and a dyslectic font</item>
<item>Verify a share recipient in a video call; 2FA with Signal &amp; Telegram</item>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any, I would mention that 2FA via SMS is now supported. In contrast to Signal and Telegram, this has been tested more thoroughly. Still, the whole app must not be considered production ready. It's an early beta at best.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a general note, I always feel way more comfortable to only announce features that are done and stable.
Otherwise it leads to more pressure to the devs (and we all have plenty of things to do).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jospoortvliet that feedback is still there (and I still agree, but whatever i prefer a decision and see PD as owner of that).

@MorrisJobke
Copy link
Member

@blizzz I added a commit that uses the new formatting that is then also used by the script to re-generate the XML files.

@blizzz
Copy link
Member

blizzz commented Aug 21, 2018

@MorrisJobke roger. lemme adjust em tests

white spaces essentially
@MorrisJobke
Copy link
Member

@MorrisJobke roger. lemme adjust em tests

But this is not good, because then we need to update the tests on every transifex sync.

<changelog href="https://nextcloud.com/changelog/#14-0-0"/>
<whatsNew lang="en">
<regular>
<item>Verify a share recipient in a video call; 2FA with Signal &amp; Telegram</item>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still an issue, but I would merge it as it is now and then update it later on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open a new issue for it

@MorrisJobke
Copy link
Member

Because then the transifex bot can do it's job already ;)

@MorrisJobke MorrisJobke merged commit 89609d4 into master Aug 22, 2018
@MorrisJobke MorrisJobke deleted the shorten-changes branch August 22, 2018 08:30
@blizzz
Copy link
Member

blizzz commented Aug 22, 2018

But this is not good, because then we need to update the tests on every transifex sync.

🤔 having working tests is a nice thing to do… perhaps checking instead for part of the content should be it

Because then the transifex bot can do it's job already ;)

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants