Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress tweaks #947

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Cypress tweaks #947

merged 5 commits into from
Oct 23, 2023

Conversation

max-nextcloud
Copy link
Collaborator

📝 Summary

  • Navigate inside the collective instead of loading the entire page again.
  • introduce basic navigation actions

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@max-nextcloud max-nextcloud force-pushed the test/fix-cypress branch 4 times, most recently from bed3672 to fd1b31d Compare October 22, 2023 14:52
Navigate inside the collective instead of loading the entire page again.

Original test run: 57 sec.
After this commit: 42 sec.

Signed-off-by: Max <[email protected]>
`A Collective` also contains the string `Collec`.
Make sure to pick the toplevel folder
rather than the mountpoint of `A Collective`.

Signed-off-by: Max <[email protected]>
@max-nextcloud max-nextcloud marked this pull request as ready for review October 23, 2023 16:11
@max-nextcloud max-nextcloud requested a review from mejo- October 23, 2023 16:11
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@mejo- mejo- merged commit 984866f into main Oct 23, 2023
32 checks passed
@juliusknorr
Copy link
Member

So great to see that CI passing ❤️

@mejo- mejo- deleted the test/fix-cypress branch November 20, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants