allow empty string for extra llm params

Signed-off-by: Julien Veyssier <[email protected]>
nextcloud · May 6, 2024 · c3c0bc2 · c3c0bc2
1 parent 06f695b
commit c3c0bc2
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/Service/OpenAiSettingsService.php b/lib/Service/OpenAiSettingsService.php
@@ -391,9 +391,11 @@ public function setMaxTokens(int $maxTokens): void {
 	}
 
 	public function setLlmExtraParams(string $llmExtraParams): void {
-		$paramsArray = json_decode($llmExtraParams, true);
-		if ($paramsArray === null) {
-			throw new Exception('Invalid model extra parameters');
+		if ($llmExtraParams !== '') {
+			$paramsArray = json_decode($llmExtraParams, true);
+			if (!is_array($paramsArray)) {
+				throw new Exception('Invalid model extra parameters, must be a valid JSON object string or an empty string');
+			}
 		}
 		$this->config->setAppValue(Application::APP_ID, 'llm_extra_params', $llmExtraParams);
 	}