improve test bootstrap, don't catch every exception in service::reque…

…st (#125)

Signed-off-by: Julien Veyssier <[email protected]>

lib/Controller/OpenAiAPIController.php

@@ -13,7 +13,6 @@
 
 use Exception;
 use OCA\OpenAi\Service\OpenAiAPIService;
-use OCA\OpenAi\Service\OpenAiSettingsService;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\Attribute\NoAdminRequired;
@@ -25,7 +24,6 @@ public function __construct(
 		string $appName,
 		IRequest $request,
 		private OpenAiAPIService $openAiAPIService,
-		private OpenAiSettingsService $openAiSettingsService,
 		private ?string $userId,
 	) {
 		parent::__construct($appName, $request);

lib/Service/OpenAiAPIService.php

@@ -30,7 +30,6 @@
 use OCP\Lock\LockedException;
 use Psr\Log\LoggerInterface;
 use RuntimeException;
-use Throwable;
 
 /**
  * Service to make requests to OpenAI/LocalAI REST API
@@ -740,9 +739,6 @@ public function request(?string $userId, string $endPoint, array $params = [], s
 			} else {
 				throw new Exception($this->l10n->t('API request error: ') . $e->getMessage(), intval($e->getCode()));
 			}
-		} catch (Exception|Throwable $e) {
-			$this->logger->warning('API request error : ' . $e->getMessage(), ['exception' => $e]);
-			throw new Exception($this->l10n->t('Unknown API request error.'), Http::STATUS_INTERNAL_SERVER_ERROR);
 		}
 	}
 }

tests/bootstrap.php

@@ -1,6 +1,9 @@
 <?php
 
+use OCP\App\IAppManager;
+use OCP\Server;
+
 require_once __DIR__ . '/../../../tests/bootstrap.php';
 
-\OC_App::loadApps();
+Server::get(IAppManager::class)->loadApps();
 OC_Hook::clear();