Migrate to the new task processing API #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
force-pushed
the
enh/task-processing
branch
3 times, most recently
from
a5d15d0 to
c867b25
Compare
julien-nc
force-pushed
the
enh/task-processing
branch
from
c867b25 to
78e25fb
Compare
julien-nc
force-pushed
the
enh/task-processing
branch
2 times, most recently
from
d6bc49d to
064d182
Compare
marcelklehr
reviewed
Jun 25, 2024
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/task-processing
branch
from
064d182 to
c43200a
Compare
Signed-off-by: Julien Veyssier <[email protected]>
…custom one Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
…t push sensitive values to the frontend Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/task-processing
branch
from
5c14209 to
48cd8bd
Compare
marcelklehr
reviewed
Jul 17, 2024
| throw new RuntimeException('Invalid prompt'); | ||
| } | ||
| $prompt = $input['input']; | ||
| $prompt = 'Extract topics from the following text. Detect the language of the text. Use the same language as the text. Output only the topics. Here is the text:' . "\n\n" . $prompt; |
There was a problem hiding this comment.
Ideally the output should be comma separated, so it can be used programmatically.
marcelklehr
reviewed
Jul 17, 2024
| } | ||
|
|
||
| try { | ||
| $completion = $this->openAiAPIService->createChatCompletion($this->userId, $adminModel, $userPrompt, $systemPrompt, $history, 1, $maxTokens); |
There was a problem hiding this comment.
Does this take into account the roles? ie. that the role of history[0] is user?
marcelklehr
reviewed
Jul 17, 2024
| $systemPrompt = $input['system_prompt']; | ||
|
|
||
| if (!isset($input['history']) || !is_array($input['history'])) { | ||
| throw new RuntimeException('Invalid history'); |
There was a problem hiding this comment.
Great to have validation on this!
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge IMO.