Cache models in a class attribute to avoid one network request per provider #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As OpenAI apparently has rate limit on the models endpoint, page loading and requests to
/ocs/v2.php/apps/assistant/api/v1/task-types
can be slowed down quite a bit because each provider gets the list of models to populate the enum value in their optional input shapes.Thankfully they all use the same instance of
OpenAiAPIService
so the model request response can be simply cached in a class attribute.