fix: update license identifiers, bump minimum Nextcloud version #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Ly <[email protected]>
edward-ly
force-pushed
the
fix/license
branch
from
2195346 to
3ac01ff
Compare
edward-ly
changed the title
kyteinsky
reviewed
Jan 23, 2025
| <licence>agpl</licence> | ||
| <licence>AGPL-3.0-or-later</licence> |
There was a problem hiding this comment.
this should be agpl, see the info.xml lint workflow
kyteinsky
reviewed
Jan 23, 2025
| <nextcloud min-version="28" max-version="31"/> | ||
| <nextcloud min-version="31" max-version="31"/> |
There was a problem hiding this comment.
does this integration not work with versions below 31?
let's keep the compatibility as long as possible, if possible.
|
The plan was to merge this after nextcloud/appstore#1560, but looking at that PR again, it does makes more sense now that the new license should be applied to new apps first or when something else forces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
AGPL-3.0-or-lateridentifiers wherever possible (requires Nextcloud 31 or higher).