Fix tiles not working on public pages because of missing CSP entries #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A CSP entry for https://tile.openstreetmap.org was introduced in 8e9e960, but it was only added to the PageController but it should be added to all the places where the CSP headers are generated. Signed-off-by: chefe <[email protected]>
chefe
force-pushed
the
fix-tiles-not-working-on-public-favorite-share-page
branch
from
872f9fc to
b1dec52
Compare
|
@chefe good catch thanks. |
tacruc
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CSP entry for https://tile.openstreetmap.org was introduced in 8e9e960, but it was only added to the PageController but it should be added to all the places where the CSP headers are generated.
cc @tacruc, @Ma27