Merge pull request #49288 from nextcloud/smb-acl-fail-soft

fix: smb: don't fail hard if we can't load acls for a file
nextcloud · Dec 4, 2024 · 0e10bb5 · 0e10bb5
2 parents 1ef3e3e + cc39714
commit 0e10bb5
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/apps/files_external/lib/Lib/Storage/SMB.php b/apps/files_external/lib/Lib/Storage/SMB.php
@@ -193,7 +193,12 @@ protected function throwUnavailable(\Exception $e): never {
 	 * get the acl from fileinfo that is relevant for the configured user
 	 */
 	private function getACL(IFileInfo $file): ?ACL {
-		$acls = $file->getAcls();
+		try {
+			$acls = $file->getAcls();
+		} catch (Exception $e) {
+			$this->logger->error('Error while getting file acls', ['exception' => $e]);
+			return null;
+		}
 		foreach ($acls as $user => $acl) {
 			[, $user] = $this->splitUser($user); // strip domain
 			if ($user === $this->server->getAuth()->getUsername()) {