Skip to content

Commit

Permalink
fix(status): Avoid session creation for status requests
Browse files Browse the repository at this point in the history
Signed-off-by: Git'Fellow <[email protected]>
  • Loading branch information
solracsf authored Nov 20, 2024
1 parent 3822db5 commit 59d4d1d
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions lib/base.php
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,14 @@ private static function printUpgradePage(\OC\SystemConfig $systemConfig): void {
public static function initSession(): void {
$request = Server::get(IRequest::class);

// Do not initialize sessions for 'status.php' requests
// Monitoring endpoints can quickly flood session handlers
// and 'status.php' doesn't require sessions anyway
$isStatusRequest = str_starts_with($request->getRequestUri(), '/status.php');
if ($isStatusRequest === true) {
return;
}

// TODO: Temporary disabled again to solve issues with CalDAV/CardDAV clients like DAVx5 that use cookies
// TODO: See https://github.com/nextcloud/server/issues/37277#issuecomment-1476366147 and the other comments
// TODO: for further information.
Expand Down

0 comments on commit 59d4d1d

Please sign in to comment.