fix(ISSUE_TEMPLATE): Search closed issues by default too #49382
Conversation
I propose to remove the state:open from the link to include closed issues in the search by default. I just raised a duplicate ticket because I searched via the link and (of course) didn't see the issue was reported and closed multiple times. Signed-off-by: Stefan <[email protected]>
There was a problem hiding this comment.
Thanks, @tryallthethings, for taking the time to propose this!
I'm all for it!
(I had started a similar change back in #44322, but I ended up sticking a couple other unrelated changes in that one that I had mixed feelings about. I never got around to going back and splitting those out so I let it go stale.)
Let's use your PR - it's more focused - and let's get this change live. :-)
I also vote for @szaimen's suggestion, but I'll leave the final call to you.
P.S. You'll have to fix your commit since we require "conventional commit" style commit messages.
joshtrichards
changed the title
Sure, this is a good addition. Co-authored-by: Simon L. <[email protected]> Signed-off-by: Stefan <[email protected]>
|
@joshtrichards Where exactly can / should I change my commit? I'm not familar with this and don't see any way to edit existing commits? |
joshtrichards
changed the title
Normally I'd personally do an interactive rebase in Another option would be to create a new PR from scratch to replace this one (since that would allow you to generate a new commit). |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
I propose to remove the state:open from the link to include closed issues in the search by default. I
just raised a duplicate ticket because I searched via the link and (of course) didn't see the issue was reported and closed multiple times.
Summary
TODO
N/A
Checklist
N/A