Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UserAgent of Thunderbird Add-on to *cloud #50018

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joendres
Copy link

@joendres joendres commented Jan 2, 2025

  • Resolves: Not reported as an issue.

Summary

In Automated Tagging Flows there is an option to filter by "Request user agent" which has an option "Thunderbird & Outlook addons". For the Thunderbird Addon this activates a filter for the User-Agent of the old, discontinued Nextcloud for Filelink Add-on. The current Add-on is *cloud - FileLink for Nextcloud and ownCloud which sends its own User-Agent.

This patch exchanges the User-Agent of the discontinued Add-on with that of the current one.

Checklist

Sorry, something went wrong.

@joendres joendres marked this pull request as draft January 2, 2025 18:01
@joendres joendres force-pushed the thunderbird-addon-useragent branch from 215967f to c7538bb Compare January 2, 2025 18:03
@joendres joendres marked this pull request as ready for review January 2, 2025 18:07
@joendres joendres changed the title Change UserAgent to *cloud Change UserAgent of Thunderbird Add-on to *cloud Jan 2, 2025
@kesselb
Copy link
Contributor

kesselb commented Jan 3, 2025

Thanks for your pull request 🙏

It seems your pr contains a couple of unrelated changes. Can you rebase on top of the latest master and drop them?

Signed-off-by: Johannes Endres <[email protected]>
@joendres joendres force-pushed the thunderbird-addon-useragent branch from 570b4a9 to f235fe3 Compare January 4, 2025 14:54
@joendres
Copy link
Author

joendres commented Jan 4, 2025

It seems your pr contains a couple of unrelated changes. Can you rebase on top of the latest master and drop them?

Did that just now.

Co-authored-by: Daniel <[email protected]>
Signed-off-by: Johannes Endres <[email protected]>
@joendres joendres force-pushed the thunderbird-addon-useragent branch 2 times, most recently from c0a01c0 to a353dbb Compare January 4, 2025 17:55
Co-authored-by: Daniel <[email protected]>
Signed-off-by: Johannes Endres <[email protected]>
@kesselb kesselb mentioned this pull request Jan 6, 2025
7 tasks
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants