Harden files_sharing API #50052
Merged
Harden files_sharing API #50052
+65
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
nfebe,
a team,
ArtificialOwl and
icewind1991
and removed request for
a team
Merged
come-nc
approved these changes
Jan 13, 2025
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/files_sharing/harden-api
branch
from
9530727 to
1e28657
Compare
icewind1991
approved these changes
Jan 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #47825
I wasn't able to fix all errors I found via fuzzing, but the remaining ones are not critical and some not solvable at all (e.g. >64 bit integer input overflowing and becoming negative such that the offset for the database query is invalid).
Checklist