feat(files_sharing): add send mail toggle

[nfebe]

Summary

For new internal shares, show the user a toggle for them configure if they want to send the share receiver a notification mail.

This is subject to whether the configured user has an email send up

• Resolves: [Bug]: New Share to Local User Does Not Trigger Email Notification (sharebyemail) #49954

Screenshots

Inactive	Active

TODO

• Ensure no failure if activating toggle does not lead to errors for users without configured emails

[skjnldsv]

Why not put it to true straight away?

[nfebe]

Why not put it to true straight away?

This sounds okay, but should not require another review cycle?

cc: @skjnldsv

[nfebe]

Addressed.

[nfebe]

Suggested change

	sendNotificationMailOnCreation: true,
	sendNotificationMailOnCreation: true,

[sushifrick]

Being the customer who opened the ticket that lead to the issue #49954, this would not fix our initial problem.

Our users have to accept shares, and are used to accept the shares by the link in the mail. Like hier in a gif from our user documentation. The link in the mail directly accepts the share.

Now the shares are listed as pending, but users do not find those. They get notifications about changes on shared folders and if they open the internal links from the notfications, they get a file not found error. No mention of the pending shares. Then they contact the support.

So i am not against the optional mails presented here in general, but would love an admin option to overrule it and enforce the mails.

Kind regards
Sascha

[nfebe]

Our users have to accept shares, and are used to accept the shares by the link in the mail.

Hello @sushifrick thanks for you comment, I am afraid the issue you described is completely different from the one the linked ticket is resolving.

• The ticket links describes a situation where shares do not trigger emails
• The situation you described (based on the quoted statement) indicates that share links cannot be used to accept shares anymore, not the same thing.

It would be nice to check back on your ticket to make sure the right thing is being addressed.

[provokateurin]

Didn't test, but looks good.
I think for such a critical thing you should add a test that ensures the mail is sent/not sent based on the toggle input.

[sushifrick]

Dear @nfebe,

Hello @sushifrick thanks for you comment, I am afraid the issue you described is completely different from the one the linked ticket is resolving.

I do not think so. The problem is not that link in the mails do not accept the share. The problem is that the mails simply do not exist anymore right now. I have no idea, what links are in the mail and weather those links might or might not accept the share. I would hope so, as this was the state before. I am not even sure when the mails went missing, but each internal share did notify the receivers via mail before. Might be a couple of versions back, when it went missing, though.

But I want to emphasize, that this new optional email notifications are different from how it was before. Each new share triggered a (non optional) mail, even independent on the users notification settings. And that was a good thing. Users need to know about new shares. And as the admin I would like to force those mails again, or at least be able set the default to true. This is missing here.

[nfebe]

Hello @sushifrick in that case #49898 solves your problem and then this PR gives the user control over the behavior in the UI.