Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply enforce theme config for anonymous users as well #50076

Merged

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Jan 7, 2025

Fixes #49086

Summary

Reproducer:

  1. change config to 'enforce_theme' => 'dark',
  2. upload a file and share it to public
  3. open public link as anonymous

Expected: dark theme is used.
Actual: default light theme is used.

Checklist

@joshtrichards
Copy link
Member

/backport to stable30

@joshtrichards
Copy link
Member

/backport to stable29

@joshtrichards joshtrichards force-pushed the bugfix/fix-enforce-theme-for-public-links branch from 5db699a to 6dcb291 Compare January 7, 2025 21:53
@Koc Koc force-pushed the bugfix/fix-enforce-theme-for-public-links branch from 6dcb291 to 438528b Compare January 7, 2025 23:31
@blizzz blizzz mentioned this pull request Jan 8, 2025
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane

@susnux
Copy link
Contributor

susnux commented Jan 10, 2025

Branch for running CI: #50118

@Koc
Copy link
Contributor Author

Koc commented Jan 10, 2025

@susnux yeah, my bad, I've forgot to push my branch to original repository

@sorbaugh sorbaugh merged commit b2c7491 into nextcloud:master Jan 10, 2025
340 of 364 checks passed
@Koc Koc deleted the bugfix/fix-enforce-theme-for-public-links branch January 10, 2025 11:52
@skjnldsv skjnldsv mentioned this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Theming: Force Light or Dark Theme Regardless of System
5 participants