Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use displayname as sidebar title #50107

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jan 9, 2025

Before After
Screenshot From 2025-01-09 13-41-00 Screenshot From 2025-01-09 13-40-27

Useful for E2EE in the browser where name and displayname are not the same.

@artonge artonge requested a review from skjnldsv as a code owner January 9, 2025 12:44
@artonge artonge self-assigned this Jan 9, 2025
@artonge artonge added bug javascript feature: file sidebar Related to the file sidebar component 3. to review Waiting for reviews labels Jan 9, 2025
@artonge artonge added this to the Nextcloud 31 milestone Jan 9, 2025
@artonge artonge changed the title fix: File name in sidebar fix: Use displayname as sidebar title Jan 9, 2025
@artonge artonge force-pushed the artonge/fix/displayname_in_sidebar branch from 6f6b742 to 3788342 Compare January 9, 2025 12:48
@joshtrichards
Copy link
Member

/compile amend /

Keep the fallback with this.fileInfo as this.node could be null

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the artonge/fix/displayname_in_sidebar branch from 3788342 to ec778a0 Compare January 9, 2025 15:38
@skjnldsv skjnldsv enabled auto-merge January 9, 2025 16:24
@skjnldsv skjnldsv merged commit 2f75452 into master Jan 9, 2025
120 checks passed
@skjnldsv skjnldsv deleted the artonge/fix/displayname_in_sidebar branch January 9, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: file sidebar Related to the file sidebar component javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants