Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not duplicate / in davPath #50108

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jan 9, 2025

davRootPath already contains a leading /

Screenshot From 2025-01-09 13-12-53

@artonge artonge added bug javascript feature: file sidebar Related to the file sidebar component labels Jan 9, 2025
@artonge artonge added this to the Nextcloud 31 milestone Jan 9, 2025
@artonge artonge self-assigned this Jan 9, 2025
@artonge artonge requested a review from skjnldsv as a code owner January 9, 2025 12:46
@joshtrichards
Copy link
Member

/compile amend /

Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Matches implementation as well as how we're doing this elsewhere.

@nextcloud-command nextcloud-command force-pushed the artonge/fix/sidebar_davpath branch from 7e26adb to defa629 Compare January 9, 2025 16:07
`davRootPath` already contains a leading `/`

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@artonge artonge force-pushed the artonge/fix/sidebar_davpath branch from defa629 to 5d078b3 Compare January 9, 2025 16:43
@artonge artonge enabled auto-merge January 9, 2025 16:43
@artonge artonge merged commit a850a0b into master Jan 9, 2025
120 checks passed
@artonge artonge deleted the artonge/fix/sidebar_davpath branch January 9, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature: file sidebar Related to the file sidebar component javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants