fix(dashboard): don't initially load items of hidden api widgets #50152
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
bug
3. to review
|
/backport to stable30 |
|
/backport to stable29 |
|
Is there a way to test this? (To prevent regressions in the future) |
nickvergessen
approved these changes
Jan 13, 2025
Load the dashboard, and check how much API requests are done? But it's kind of complicated and most/all widgets are enabled by default? |
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
fix/dashboard/dont-load-hidden-widgets-initially
branch
from
2205d2d to
0bb7be2
Compare
st3iny
added
4. to release
This was referenced Jan 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before: Load items of all widgets on page load even if some are hidden.
After: Only load items of widgets that are actually enabled initially. Load items of toggled widgets on demand as soon as they are enabled.
Checklist