fix(files): sort not working after changing views #50161
Draft
+87
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable30 |
|
/backport to stable29 |
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
fix/files/sort-after-view-change
branch
from
446823a to
1c3ec2a
Compare
susnux
reviewed
Jan 14, 2025
Comment on lines
+53
to
+60
| const actualNavigation = getNavigation() | ||
| actualNavigation.addEventListener('update', () => { | ||
| Vue.set(Navigation, 'views', actualNavigation.views) | ||
| Vue.set(Navigation, 'active', actualNavigation.active) | ||
| }) | ||
| actualNavigation.addEventListener('updateActive', () => { | ||
| Vue.set(Navigation, 'active', actualNavigation.active) | ||
| }) |
There was a problem hiding this comment.
This should already be handled by the useNavigation composable.
Seems like mixin/filesSorting.ts is the last place that uses the $navigation property directly.
Maybe just replace the usage of this.$navigation then this whole object can be dropped.
There was a problem hiding this comment.
There already is a composable for this? I feel stupid now ...
I'll refactor the code then and get rid of the global prop.
st3iny
added
2. developing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sorting the tabular view in files breaks if the view is changed twice.
Not a beautiful solution but it works ...
How to reproduce?
Problem: The global
$navigationobject is not reactive enough and misses some changes.Before
2025-01-14.13-49-24.mp4
After
2025-01-14.13-51-11.mp4
TODO
Checklist