Limit ldap user count #50171
Open
Limit ldap user count #50171
+106
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… performances Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
…ckend Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Merged
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
nickvergessen,
blizzz,
a team,
icewind1991,
Altahrim and
nfebe
and removed request for
a team
|
cypress failure is unrelated |
blizzz
reviewed
Jan 14, 2025
|
|
||
| foreach ($this->backends as $backend) { | ||
| if ($onlyMappedUsers && $backend instanceof ICountMappedUsersBackend) { | ||
| $backendUsers = $backend->countMappedUsers(); |
There was a problem hiding this comment.
less relevant, but it could benefit from a limit as well?
| */ | ||
| public function countUsers() { |
| if ($this->userPluginManager->implementsActions(Backend::COUNT_USERS)) { | ||
| return $this->userPluginManager->countUsers(); | ||
| } | ||
|
|
||
| $filter = $this->access->getFilterForUserCount(); | ||
| $cacheKey = 'countUsers-' . $filter; | ||
| $cacheKey = 'countUsers-' . $filter . '-' . $limit; |
There was a problem hiding this comment.
not necessary, the cache is being flushed after configuration changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This avoids listing all LDAP users only to check if there are more than 100 for the
updatenotificationapplication. This speeds up opening admin settings a lot on big instances with LDAP backend.The new user count limit is made so that it can be implemented in other backends if needed, and places calling the user count only to compare against a threshold have been adapted to set a limit.
Checklist