feat(contacts): Show time difference for users in different timezones #50214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
requested review from
jancborchardt,
yemkareems,
marcoambrosini,
sorbaugh and
come-nc
Merged
sorbaugh
approved these changes
Jan 17, 2025
| $timeOffsetString = $l->t('%s behind', [$timeOffsetString]); | ||
| } | ||
| } | ||
| $profileActionText = "{$localTimeString} • {$timeOffsetString}"; |
There was a problem hiding this comment.
Should be translated, so that RTL languages also have first the time and then the "offset"?
There was a problem hiding this comment.
Normally this should also work, we do the same for app headlines and page titles on the frontend.
But if preffered I can add this as translated
There was a problem hiding this comment.
Maybe @DorraJaouad can give it a quick test with arabic to see how it feels?
There was a problem hiding this comment.
Yeah, it looks good, offset comes in second position
jancborchardt
approved these changes
Jan 20, 2025
yes! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the time offset to a different user in a different timezone to the account menu.
Screen recording
Bildschirmaufnahme_20250116_130919.webm
Checklist