chore : Comprehensive e2e testing for public sharing #50260
+306
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
enhancements/files-sharing-tests
branch
4 times, most recently
from
088f24e to
2133889
Compare
nfebe
changed the title
nfebe
changed the title
susnux
reviewed
Jan 20, 2025
artonge
reviewed
Jan 21, 2025
| const { dataSnapshot, shareUrl } = data as any || {} | ||
| if (dataSnapshot) { | ||
| cy.restoreState(dataSnapshot) | ||
| defaultShareContext.url = shareUrl |
There was a problem hiding this comment.
If you set one of its property, it is not a default anymore.
There was a problem hiding this comment.
I don't get the purpose of defaultShareContext. It is a global variable that is used only in this file, but is also passed as an argument in the functions in this file. Feels confusing. And it is mainly used to provide the User object and to receive the url. Can't we use an argument and the return value instead?
Can't we do without?
There was a problem hiding this comment.
That method is being used in other tests in away that does not provide parameters those tests just need some or a public link to exist.
This file has now been repurposed to continue serving those tests while this new scenario.
cypress/e2e/files_sharing/public-share/required-before-create.cy.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/files_sharing/public-share/required-before-create.cy.ts
Outdated
Show resolved
Hide resolved
8 tasks
nfebe
force-pushed
the
enhancements/files-sharing-tests
branch
from
2133889 to
4b32508
Compare
This update enhances the testing framework for public sharing by improving the setup and management of share contexts. It refactors the code to make the `createShare` function reusable externally, ensuring better testability and flexibility. Additionally, the update optimizes share permission adjustments and improves state management, making public share setups more efficient and maintainable. Signed-off-by: nfebe <[email protected]>
This commit introduces end-to-end tests for various public link sharing scenarios in the `files_sharing` app. It validates the behavior under multiple configurations: - Password and expiration date enforced - Password enforced with a default expiration date - Expiration date enforced with optional password - Default password and expiration date without enforcement - Password enforced, expiration date set but not enforced - Both password and expiration date not enforced, but defaults set - Password not enforced, expiration date enforced - Password not enforced, default expiration date set - Password and expiration date not enforced with no defaults The tests ensure proper validation and functionality of the configurations, leveraging the `setupData` and `createShare` utilities. Signed-off-by: nfebe <[email protected]>
Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
enhancements/files-sharing-tests
branch
from
4b32508 to
96b7fdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the testing framework for public sharing by introducing modular improvements and extending test coverage with "before create public share" checks.
Adds the following tests:
Screencast for e2e plays
public-sharing-e2e-tests.mp4