#187 Populate avatar from SAML attribute #740
Open
+103
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RickBruyninckx
force-pushed
the
master
branch
2 times, most recently
from
d293264 to
879714b
Compare
Signed-off-by: Rick Bruyninckx <[email protected]>
Signed-off-by: Rick Bruyninckx <[email protected]>
Signed-off-by: RickBruyninckx <[email protected]>
|
Can we expect this to be merged (soon)? 🤔 |
I don't expect it to happen anymore... This PR was created 211 days ago but I don't think anyone is willing to review it. |
Sad. |
|
Sorry. I was actually starting to look into it quite a while ago… but don't have a good setup for smoke testing it. Generally the code looked fine iirc. Have to revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #187.
The code is coppied from Lumrenion but his PR seems stale so I'm giving it a shot.
In admin configuration, a new configuration field avatar_mapping is added.
If avatar_mapping configuration field is not empty, the user wont be able to upload an image in the nextcloud profile settings
The avatar_mapping field holds a publicly available URL to the profile image of the user. As usual, the image will be downloaded to nextcloud when the user logs in via user_saml.