Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Implement IGetDisplayNameBackend #773

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: Implement IGetDisplayNameBackend #773

merged 1 commit into from
Oct 23, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 23, 2023 •
edited
Loading

Backport of #771

danxuliu
danxuliu reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sane, but I have not tested it.

@juliusknorr juliusknorr merged commit 6c41a27 into stable-5.2 Oct 23, 2023
@juliusknorr juliusknorr deleted the backport/771/stable-5.2 branch October 23, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu left review comments

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @danxuliu @come-nc