Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(idps): Allow to filter idps based on trusted domains #815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlehtoranta
Copy link

A Nextcloud installation might be available via multiple trusted domains (e.g. nextcloud.a.com and nextcloud.b.com). In this case an admin might want to link idps with specific trusted domains. For example associating only idp.a.com with nextcloud.a.com would redirect automatically to the idp login page, while at the same time there could still be multiple idps available via nextcloud.b.com.

@blizzz
Copy link
Member

blizzz commented Mar 20, 2024

Hi @jlehtoranta that looks good on first sight! Would it be possible for you to extend the feature with integration tests?

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants