Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore checkPassword() function #828

Closed
wants to merge 1 commit into from
Closed

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Apr 2, 2024

Regression from PR #808

@solracsf
Copy link
Member Author

solracsf commented Apr 2, 2024

Seems the whole PR needs to be reverted instead...

@solracsf solracsf closed this Apr 2, 2024
@solracsf solracsf deleted the restore-checkPassword branch April 2, 2024 07:43
@jejbq
Copy link

jejbq commented Apr 3, 2024

Hello,

We are also affected by this issue #825 #826 #829
so WebDAV does not work anymore ...

If you cannot rollback PR #808 , we will switch our Nextcloud AIO from SAML2 (user_saml) to OAuth2 (OIDC Connect)

Thank you in advance.

curl --user '*********:***************' -X PROPFIND -H "Depth: 1" 'https://nextcloud.example.com/remote.php/dav/files/username/'
<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Error</s:exception>
  <s:message>Call to undefined method OCA\User_SAML\UserBackend::checkPassword()</s:message>
</d:error>

@blizzz
Copy link
Member

blizzz commented Apr 3, 2024

#829 is the a pull request with the fix…

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants