Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Makefile and add option to compile and install to the plugins directory #73

Merged
merged 1 commit into from
Dec 21, 2023
Merged

update Makefile and add option to compile and install to the plugins directory #73

merged 1 commit into from
Dec 21, 2023

Conversation

mirpedrol
Copy link
Collaborator

This PR is based on the new additions to nf-validation: nextflow-io/nf-validation#126
Implements the make install rule from nf-prov.
Switches to using NXF_PLUGINS_DIR as install location.

@mirpedrol mirpedrol requested a review from skrakau December 21, 2023 09:20
skrakau
skrakau approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I am not sure about the details, but sounds good to me :)

@mirpedrol mirpedrol merged commit 3f7dbc2 into nextflow-io:dev Dec 21, 2023
2 checks passed
@mirpedrol mirpedrol deleted the make-install branch December 21, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrakau skrakau skrakau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirpedrol @skrakau