Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix samplename in repeat call vcfs #656

Closed
wants to merge 161 commits into from
Closed

Fix samplename in repeat call vcfs #656

wants to merge 161 commits into from

Conversation

ramprasadn
Copy link
Collaborator

PR checklist

Sample names in the vcf from repeat calling subworkflow contains suffixes added in the alignment subworkflow. This PR fixes that issue.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ramprasadn ramprasadn closed this Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @ramprasadn,

It looks like this pull-request is has been made against the nf-core/raredisease master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/raredisease dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

Copy link

github-actions bot commented Jan 7, 2025

nf-core pipelines lint overall result: Failed ❌

Posted for pipeline commit 3fbae07

+| ✅ 201 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   2 tests had warnings |!
-| ❌   3 tests failed       |-

❌ Test failures:

  • nextflow_config - Config manifest.version should not contain dev for a release: 2.3.0dev
  • version_consistency - manifest.version was not numeric: 2.3.0dev!
  • included_configs - Pipeline config does not include custom configs. Please uncomment the includeConfig line.

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-raredisease_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-raredisease_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-raredisease_logo_dark.png
  • modules_config - modules_config

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2025-01-07 15:16:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants